[codemod] Fix incorrect slot name in tab-props.js (scrollButton → scrollButtons) #47215
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-47215--material-ui.netlify.app/ Bundle size report
|
Contributor
Author
|
@ZeeshanTamboli @sai6855 Please check this PR. |
Contributor
Author
|
@siriwatknp I am confused. Should it be scrollButton or scrollButtons. In MUI Docs, it is scrollButtons but ideally it should be scrollButton |
Member
In the code it's plural: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Tabs/Tabs.js#L575C63-L575C76 |
Contributor
Author
|
@ZeeshanTamboli I tried pushing the empty commit but the CI is not getting triggered |
Member
|
@siriwatknp There's a lot of inconsistency here.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an incorrect slot name in the
mui-codemodtransformer forTabsprops.In
tab-props.js, the codemod currently movesTabScrollButtonPropsinto a slot namedscrollButton(singular).However, according to the Tabs API, the correct slot is
scrollButtons(plural).